feat(express-engine): add ModuleMapLoaderModule to the app server imports during ng-add#1130
feat(express-engine): add ModuleMapLoaderModule to the app server imports during ng-add#1130
Conversation
…orts during ng-add
CaerusKaru
added
action: review
area: express-engine
target: minor
| export function findAppServerModulePath(host: Tree, mainPath: string): string { | ||
| const exportDeclaration = findAppServerModuleExport(host, mainPath); | ||
| if (!exportDeclaration) { | ||
| throw new SchematicsException('Export declaration not found'); |
There was a problem hiding this comment.
It's not clear to me from the error message what 'Export declaration' is referring to. Maybe specify Internal Error if the error is not actually actionable by the user?
There was a problem hiding this comment.
It's referring to the export {DECLARATION} block. Do you have a suggestion to make that more apparent?
There was a problem hiding this comment.
I would have the error message indicate what sort of export declaration it was expecting - Like "Exported AppServer Module not found" or something like that instead of a generic statement like the current one.
…ver imports during ng-add
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
Fixes #1129